Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix doc tests and add CI check #2606

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix doc tests and add CI check #2606

wants to merge 1 commit into from

Conversation

jedel1043
Copy link
Member

This Pull Request fixes #2605.

It changes the following:

  • Adds a CI check to run cargo test --doc since nextest doesn't support doc tests at the moment.
  • Fixes the failing doc tests.

@jedel1043 jedel1043 added bug Something isn't working github_actions Pull requests that update Github_actions code labels Feb 18, 2023
@jedel1043 jedel1043 added this to the v0.17.0 milestone Feb 18, 2023
@jedel1043 jedel1043 mentioned this pull request Feb 18, 2023
Closed
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,129 94,129 0
Passed 71,901 71,902 +1
Ignored 17,206 17,206 0
Failed 5,022 5,021 -1
Panics 12 12 0
Conformance 76.39% 76.39% +0.00%
Fixed tests (1): 
test/built-ins/Set/valid-values.js [strict mode] (previously Failed)

@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

Merging #2606 (77c3d31) into main (f538cb2) will increase coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2606      +/-   ##
==========================================
+ Coverage   49.17%   49.43%   +0.25%     
==========================================
  Files         386      384       -2     
  Lines       38843    38629     -214     
==========================================
- Hits        19102    19097       -5     
+ Misses      19741    19532     -209
Impacted Files Coverage Δ
boa_engine/src/class.rs 0.00% <ø> (ø)
boa_engine/src/context/hooks.rs 60.00% <ø> (ø)
boa_engine/src/context/mod.rs 44.13% <ø> (ø)
boa_engine/src/lib.rs 100.00% <ø> (ø)
boa_engine/src/object/mod.rs 29.27% <ø> (ø)
boa_parser/src/lexer/cursor.rs 86.72% <0.00%> (-1.43%) ⬇️
boa_cli/src/main.rs 0.00% <0.00%> (-0.94%) ⬇️
boa_ast/src/visitor.rs 11.34% <0.00%> (-0.52%) ⬇️
boa_cli/src/helper.rs 0.00% <0.00%> (ø)
boa_examples/src/bin/classes.rs
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Razican
Razican approved these changes Feb 18, 2023
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Razican
Copy link
Member

Razican commented Feb 18, 2023

bors r+

bors bot pushed a commit that referenced this pull request Feb 18, 2023
@jedel1043
Fix doc tests and add CI check (#2606)
60c25b4 
This Pull Request fixes #2605.

It changes the following:

- Adds a CI check to run `cargo test --doc` since `nextest` doesn't support doc tests at the moment.
- Fixes the failing doc tests.
@bors
Copy link

bors bot commented Feb 18, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix doc tests and add CI check [Merged by Bors] - Fix doc tests and add CI check Feb 18, 2023
@bors bors bot closed this Feb 18, 2023
@bors bors bot deleted the fix-docs branch February 18, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@nekevss nekevss nekevss approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@RageKnify RageKnify Awaiting requested review from RageKnify

@raskad raskad Awaiting requested review from raskad

Assignees
No one assigned
Labels
bug Something isn't working github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.

cargo test fails for code in docs
3 participants
@jedel1043 @Razican @nekevss